fix: EXPOSED-602 Column name that includes table name is aliased with…

… upserts (#2287)

Dialects that use MERGE for upserts automatically have their update values aliased.
Since version 0.54.0, update values that should be the same as insert values are
wrapped as a special expression. This means they are processed like any expression
and any potential inclusion of the table name is replaced with alias 'T'. This
causes invalid identifiers if the actual column to update uses an identifier
that includes the table name. Restricting the case for string replacement
fixes this.

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/FunctionProvider.kt

@@ -724,7 +724,7 @@ abstract class FunctionProvider {
                 append("T.${transaction.identity(columnToUpdate)}=")
                 when (updateExpression) {
                     is QueryParameter<*>, !is Expression<*> -> registerArgument(columnToUpdate.columnType, updateExpression)
-                    else -> append(updateExpression.toString().replace(tableIdentifier, "T"))
+                    else -> append(updateExpression.toString().replace("$tableIdentifier.", "T."))
                 }
             }
 

exposed-tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/shared/dml/UpsertTests.kt

@@ -749,6 +749,24 @@ class UpsertTests : DatabaseTestsBase() {
         }
     }
 
+    @Test
+    fun testUpsertWhenColumnNameIncludesTableName() {
+        val tester = object : Table("my_table") {
+            val myTableId = integer("my_table_id")
+            val myTableValue = varchar("my_table_value", 100)
+            override val primaryKey = PrimaryKey(myTableId)
+        }
+
+        withTables(excludeSettings = TestDB.ALL_H2_V1, tester) {
+            tester.upsert {
+                it[myTableId] = 1
+                it[myTableValue] = "Hello"
+            }
+
+            assertEquals("Hello", tester.selectAll().single()[tester.myTableValue])
+        }
+    }
+
     private object AutoIncTable : Table("auto_inc_table") {
         val id = integer("id").autoIncrement()
         val name = varchar("name", 64)