Skip to content

Commit

Permalink
Merge branch 'gh-pages' into feature-homepage-launch
Browse files Browse the repository at this point in the history
  • Loading branch information
JessicaLucindaCheng committed Apr 14, 2022
2 parents 467a797 + a8a0a36 commit f49d073
Show file tree
Hide file tree
Showing 189 changed files with 9,120 additions and 4,145 deletions.
35 changes: 0 additions & 35 deletions .github/ISSUE_TEMPLATE/Mobile_responsiveness.md

This file was deleted.

48 changes: 48 additions & 0 deletions .github/ISSUE_TEMPLATE/Mobile_responsiveness.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: 'Responsiveness on mobile '
description: 'Standard HackforLA issue template '
title: 'Mobile Responsiveness on [name of the page] : [quick recap of the bug here]'
labels: ['role: design']
# assignees:

body:
- type: textarea
id: overview
attributes:
label: Overview
description: |
We need to check the mobile version of every pages on the website so that we correct any bug that is appearing on mobile.
1. Explain the bug that you have observed
2. Put a screenshot of the bug: you can use the following template to create a drop down image
value: |
<details>
<summary>TITLE IMAGE </summary>
![image](https://user-images.githubusercontent.com/77212035/134111368-bc5dfa08-0dd3-47be-a0e2-a60c6a362bf7.png)
</details>
validations:
required: true
- type: markdown
attributes:
value: "## Action Items"
- type: checkboxes
id: action-design
attributes:
label: "Design:"
options:
- label: "Check the mobile responsiveness of this page (use your mobile to do it ;) )"
- label: "If there is any bug/any inconsistency or problem, however small or large, edit this issue and list the bug with screenshots in the Overview section above. _You have more than one bug? duplicate this issue and create one issue per bug. "
- label: "List all the changes to implement to correct the bug (eg: resizing..) in the development action items below. (don't hesitate to create 1 checkbox for each changes)"
- label: "Put the issue(s) in the review column to check the feasibility with the devs. "
- type: textarea
id: action-development
attributes:
label: Development
value: |
- [ ] Implement the following changes : '_list your changes here_ '
- [ ] Ensure that the correction doesn't break any other pages that is connected to the one your changing. For that, check [the sitemap](https://www.hackforla.org/sitemap.xml)
- type: textarea
id: resources-instructions
attributes:
label: Resources/Instructions
description: Provide links to the figma file (if there is one), and to the page where the bug is observed.
validations:
required: true
36 changes: 36 additions & 0 deletions .github/ISSUE_TEMPLATE/alt-text-audit---design.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
name: Alt Text Audit - Design
about: WCAG Audit
title: Review alt text for WCAG compliance on [insert page name here] page
labels: 'Feature: Accessibility, role: design, Size: Small'
assignees: ''

---

### Overview
We need to ensure that alt text for images adhere to Web Content Accessibility Guidelines (WCAG). For this issue, we will tackle the images under the [NAME OF PAGE] page.

#### Details
Developers identified that some alt texts in the [NAME OF PAGE] page should be reviewed because they are either inaccurate or too long. Ideally, alt text should be descriptive but short and succinct. According to the WCAG page, an accompanying alt text should be short. Additionally, the Functional Accessibility Evaluator (FAE) recommends for alt text to be no more than 100 characters.

### Action Items
- [ ] Make a copy of the tab Template [Page Name]- [Status]
- [ ] With the copied tab replace [Page Name] with the page you are reviewing and [Status] with "Audit in Progress". Don't forget to remove brackets "[ ]"
- [ ] Add a link of the page your working on at the bottom in the Resources/Instructions section of this issue where it says "Google sheet Tab for your page".
- [ ] For each image on the page, identify if the alt text needs to be changed or not using the recourses below and fill out the google sheet. To locate the alt text use the Google Chrome browser, right click "inspect" to view pages code.
#### You don't have to fill out these columns: "Location in code", "Issue created Y/N", "Issue Link (if created)".
- [ ] After completing auditing each image of the page change your google sheet tabs [Status] to Audit Complete.
- [ ] Review your completed work with Design Lead or another member of the team
- [ ] Mark issue as done

Development
- [ ] Create issues for that particular alt text should be created (preferably labelled good first issue) for new developers to fix

### Resources/Instructions
For examples see the tabs of other pages completed alt text audits
[NAME of PAGE on the hackforla.org site](url)
[WCAG section on alt text](https://www.w3.org/WAI/WCAG21/Techniques/html/H37.html)
[FAE rule 4: alt text should be less than 100 characters](https://fae.disability.illinois.edu/rulesets/IMAGE_4_EN/)
[Google sheet instructions](https://docs.google.com/spreadsheets/d/1abMlPOX88zHTV29E4BFxAYwahCxgJN28Mn95cXr8jak/edit#gid=308160713)
[Google sheet template](https://docs.google.com/spreadsheets/d/1abMlPOX88zHTV29E4BFxAYwahCxgJN28Mn95cXr8jak/edit#gid=129703697)
Google sheet Tab for your page
45 changes: 45 additions & 0 deletions .github/ISSUE_TEMPLATE/alt-text-audit--dev.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
---
name: Alt Text Audit - Dev
about: Developer template to update an alt text
title: Update [INSERT PAGE HERE] alt text for images to adhere to WCAG
labels: 'Feature: Accessibility, good first issue, role: back end/devOps, role: front
end, size: 1pt'
assignees: ''

---

### Prerequisite
Please make sure you have read our **[Hack for LA Contributing Guide](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md)** before you claim/start working on an issue.

### Overview
As a developer, we need to provide clear and descriptive alt text on the `[INSERT PAGE HERE]` page so that we adhere to the Web Content Accessibility Guidelines (WCAG) and we can achieve our mission of inclusivity.

### Action Items
- [ ] Change the image alt property value within `[INSERT PATH OF FILE HERE]` (lines `[INSERT LINE NUMBER IN CODE HERE]`):

**From**
```
[INSERT ORIGINAL LINE OF CODE HERE]
```

**To:**
```
[INSERT NEW LINE OF CODE HERE]
```

- [ ] Ensure that the corresponding `[INSERT LINKED PAGE HERE]` stays the same after the change
- [ ] Ensure that the new alt text gets incorporated after the change

### Resources/Instructions

#### File and Code links you will need to review this issue
- Directory to find the page in once you have it in your IDE: `[INSERT PATH OF FILE HERE]`

- Click on the filename below to see the source file code:
`[INSERT PERMALINK FROM THE LINE IN THE SOURCE CODE HERE]`
<!-- To see an example of this permalink, uncomment the line below -->
<!-- https://github.com/hackforla/website/blob/f015a891265d56372f87e1adb1e1b6088dcfac06/_data/internal/program-areas/citizen-engagement-card.yml#L10 -->

#### Background information about the Jekyll framework (optional reading)
[Jekyll Data Files](https://jekyllrb.com/docs/datafiles/)
[Jekyll Front Matter](https://jekyllrb.com/docs/front-matter/)
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/blank-issue-form.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: 'Blank Issue '
description: 'Standard HackforLA issue template '

body:
- type: input
id: overview
attributes:
label: Overview
description: Clearly state the purpose of this issue in 2 sentences or less
validations:
required: true
- type: textarea
id: action-items
attributes:
label: Action Items
description: "List the research to be done, or the steps to be completed. Note: If the steps can be divided into tasks for more than one person, we recommend dividing it up into separate issues, or assigning it as a pair programming task."
validations:
required: true
- type: textarea
id: resources-instructions
attributes:
label: "Resources/Instructions"
description: "Provide links to resources or instructions that may help with this issue. This can include files to be worked on, external sites with solutions, documentation, etc."
validations:
required: true
- type: dropdown
id: dependency
attributes:
label: Is there a dependency?
options:
- "Yes"
- "No"
validations:
required: true
- type: textarea
id: dependency-explanation
attributes:
label: If Yes, please explain
File renamed without changes.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
name: Communities of Practice information updates
description: CoP leads use this issue to make changes to Leadership members and contact info
title: 'Communities of Practice information updates: [INSERT NAME OF Community of
Practice]'
labels: ['role: product', 'P-Feature: Communities of Practice']

body:
- type: markdown
attributes:
value: "### Overview"
- type: markdown
attributes:
value: "As a Community of Practice Co-Lead, I need my CoP's details to be up to date on the HackforLA website."
- type: markdown
attributes:
value: "### Action Items"
- type: markdown
attributes:
value: "Change CoP name: NO"
- type: markdown
attributes:
value: "Change Description: NO"
- type: markdown
attributes:
value: "Change Leadership Type: NO"
- type: markdown
attributes:
value: "Change Slack Link: NO"
- type: dropdown
id: remove-person-yes-no
attributes:
label: "Remove person(s) and info from CoP file?"
options:
- "YES"
- "NO"
validations:
required: true
- type: textarea
id: remove-person
attributes:
label: "If YES on remove person(s) edit the below to provide the information required. If NO, delete the template in the field below:"
value: "Name:"
- type: dropdown
id: add-person-yes-no
attributes:
label: "Add person(s) and info to CoP file?"
options:
- "YES"
- "NO"
validations:
required: true
- type: textarea
id: add-persons
attributes:
label: "If YES on add person(s), edit the below to provide the information required. If NO, delete the template in the field below:"
value: |
Name:
Title:
GitHub Handle:
Slack Member ID:
- type: markdown
attributes:
value: "### Resources"
- type: markdown
attributes:
value: |
folder where files are in the repo: https://github.com/hackforla/website/tree/gh-pages/_data/internal/communities
where you can see the live page: https://www.hackforla.org/communities-of-practice
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
---
name: 'Credits file template: Edit content field and remove type field'
about: Template for editing content field and removing type field in a credits file
title: Edit content field and remove type field from [INSERT FILE NAME HERE].yml credits
file
labels: 'good first issue, P-Feature: Credit, role: back end/devOps, role: front end,
size: 0.5pt'
assignees: ''

---

### Prerequisite
1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our [Getting Started page](https://www.hackforla.org/getting-started).
2. Please make sure you have read our **[Hack for LA Contributing Guide](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md)** before you claim/start working on an issue.

### Overview
As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

### Details
Currently, in each credit's yml file, there is a `content` field and a `type` field, which contains similar information. Since the fields are redundant, we decided to remove the `type` field.

Also, we changed the `content` field to the `content-type` field to make it clearer what its purpose is. The possible values for `content-type` field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

### Action Items
For the file `_data/internal/credits/[INSERT FILE NAME HERE].yml`, do the following:
- [ ] Change line [ADD LINE NUMBER WHICH HAS CONTENT] for the content field from
```
content: [INSERT THE CURRENT TEXT ON THE FILE HERE]
```
to
```
content-type: image
```

- [ ] Remove line [ADD LINE NUMBER WHICH HAS TYPE] for the type field
```
type: [INSERT THE CURRENT TEXT ON THE FILE HERE]
```

### Resources/Instructions
- This issue is tracked in the epic #2775.

#### File and Code links you will need to work on this issue
- Directory to find the page in once you have it in your IDE: `_data/internal/credits/[INSERT FILE NAME HERE].yml`

- Click on the links below to see the source file code:
[INSERT PERMALINK FOR THE LINE NUMBER WHICH HAS THE CONTENT FIELD]
[INSERT PERMALINK FOR THE LINE NUMBER WHICH HAS THE TYPE FIELD]

<!-- To see an example of a permalink for a line of code, uncomment the line below -->
<!-- https://github.com/hackforla/website/blob/598f33399cc81f3e095fe047a726eca09a595465/_data/internal/credits/act.yml#L4 -->
Loading

0 comments on commit f49d073

Please sign in to comment.