Skip to content

Commit

Permalink
apacheGH-38117: [C++][Parquet] Change DictEncoder dtor checking to wa…
Browse files Browse the repository at this point in the history
…rning log (apache#38118)

### Rationale for this change

This is a minor change, just change `DCHECK` to warning log.

### What changes are included in this PR?

change `DCHECK` to warning log.

### Are these changes tested?

no, I don't know how to test this, any idea is welcome.

### Are there any user-facing changes?

no

* Closes: apache#38117

Authored-by: mwish <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
  • Loading branch information
mapleFU authored and Jeremy Aguilon committed Oct 23, 2023
1 parent 26df515 commit 2e29986
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/src/parquet/encoding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ class DictEncoderImpl : public EncoderImpl, virtual public DictEncoder<DType> {
dict_encoded_size_(0),
memo_table_(pool, kInitialHashTableSize) {}

~DictEncoderImpl() override { DCHECK(buffered_indices_.empty()); }
~DictEncoderImpl() = default;

int dict_encoded_size() const override { return dict_encoded_size_; }

Expand Down

0 comments on commit 2e29986

Please sign in to comment.