Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle missing ieee_address #168

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

git-developer
Copy link
Contributor

Fix for #162 (comment)

@Ayush1325
Copy link
Contributor

Ayush1325 commented Mar 19, 2024

Yes, I think this should fix the regression. Seems the old parameter was initially assigned int 0 and then assigned string. While argparse should be None and string

@sultanqasim
Copy link

@JelmerT bringing this to your attention to fix #172

@LDprg
Copy link

LDprg commented May 16, 2024

Please merge this.

@git-developer
Copy link
Contributor Author

Since a separate issue exists now: Fixes #172

@defanator
Copy link

Confirmed to work with ZBDongle-P which previously threw the exception.

@mtthidoteu
Copy link

Can also confirm fixes ERROR: int() can't convert non-string with explicit base error

@schmargi91
Copy link

I can also confirm that this error ist fixed with that PR.

Verifying by comparing CRC32 calculations. Verified (match: 0xe83aa727) ERROR: int() can't convert non-string with explicit base

agross added a commit to agross/ansible-home-network that referenced this pull request Aug 26, 2024
@nicktimko nicktimko mentioned this pull request Aug 28, 2024
Copy link

@nicktimko nicktimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and confirmed to work when reflashing my Sonoff-P.

cc2538-bsl.py Outdated Show resolved Hide resolved
@damienleroux
Copy link

It solved my issue, thx a lot !!!!

Co-authored-by: Maximilian Mewes <[email protected]>
@JelmerT JelmerT merged commit 291f0f3 into JelmerT:master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.