This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
feat(module-indexer, module-api, whale-api-client): Future swap indexer and list API #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/module-api
area/module-indexer
area/module-model
area/whale-api-client
kind/feature
|
Code Climate has analyzed commit b9ec957 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
canonbrother
changed the title
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
==========================================
- Coverage 92.68% 92.62% -0.07%
==========================================
Files 128 131 +3
Lines 3844 3877 +33
Branches 499 489 -10
==========================================
+ Hits 3563 3591 +28
- Misses 271 276 +5
Partials 10 10
Continue to review full report at Codecov.
|
canonbrother
requested review from
fuxingloh,
jingyi2811 and
ivan-zynesis
as code owners
nichellekoh
previously approved these changes
May 6, 2022
jingyi2811
reviewed
May 6, 2022
|
Title should include |
jingyi2811
reviewed
May 6, 2022
jingyi2811
reviewed
May 6, 2022
jingyi2811
reviewed
May 6, 2022
|
Quite good. Some minor stuff |
jingyi2811
previously approved these changes
May 6, 2022
nichellekoh
previously approved these changes
May 6, 2022
cwkang1998
previously approved these changes
May 6, 2022
fuxingloh
suggested changes
May 7, 2022
canonbrother
dismissed stale reviews from cwkang1998, nichellekoh, and jingyi2811
via
ef8f5d7
jingyi2811
previously approved these changes
May 10, 2022
cwkang1998
previously approved these changes
May 10, 2022
|
Targetting this for |
fuxingloh
reviewed
May 17, 2022
|
We're finishing up BirthdayResearch/jellyfishsdk#580 This PR needs to be migrated to https://github.com/JellyfishSDK/jellyfish/tree/main/apps/whale-api |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Index future swap and list future swap API
Which issue(s) does this PR fixes?:
Fixes BirthdayResearch/jellyfishsdk#1484
Additional comments?: