This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
chore(indexer): removed await within test due to race condition #743
Draft
fuxingloh
wants to merge
3
commits into
main
Choose a base branch
from
fuxingloh/remove-race-condition-wait
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 5dc6879 and detected 0 issues on this pull request. View more on Code Climate. |
monstrobishi
previously approved these changes
Jan 31, 2022
Codecov Report
@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 92.31% 92.27% -0.05%
==========================================
Files 121 122 +1
Lines 3163 3183 +20
Branches 384 389 +5
==========================================
+ Hits 2920 2937 +17
- Misses 234 237 +3
Partials 9 9
Continue to review full report at Codecov.
|
Seems like the active price test failure is due to the test executing faster, or some similar difference in timing. That test has proven to be flakey, will add a ticket to investigate at some stage. |
monstrobishi
requested review from
canonbrother,
jingyi2811,
ivan-zynesis and
thedoublejay
as code owners
February 18, 2022 07:00
monstrobishi
approved these changes
Feb 18, 2022
canonbrother
approved these changes
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind chore
What this PR does / why we need it:
As suggested by @monstrobishi in #733 to remove await within tests that were added due to race condition.