This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
Add v0/:network/transactions/:id endpoint
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siradji
added
kind/feature
defichain-bot
added
area/whale-api-client
and removed
area/module-model
area/module-indexer
labels
|
Code Climate has analyzed commit 6b4dfa9 and detected 0 issues on this pull request. View more on Code Climate. |
|
@canonbrother, as you can see the tests in transaction.spec.ts are failing i guess due to dependency injection. |
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 88.12% 88.49% +0.36%
==========================================
Files 69 69
Lines 1373 1382 +9
Branches 143 144 +1
==========================================
+ Hits 1210 1223 +13
+ Misses 162 158 -4
Partials 1 1
Continue to review full report at Codecov.
|
jingyi2811
reviewed
Jul 14, 2021
jingyi2811
reviewed
Jul 14, 2021
canonbrother
approved these changes
Jul 15, 2021
jingyi2811
approved these changes
Jul 15, 2021
fuxingloh
approved these changes
Jul 15, 2021
eli-lim
pushed a commit
to BirthdayResearch/jellyfishsdk
that referenced
this pull request
Mar 28, 2022
* Get a single transaction by id endpoint * Minor fixes * Fix flaky test * Minor fixes * Implemented code review suggestion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Endpoint to get a single transaction.
Which issue(s) does this PR fixes?:
Fixes #243
Additional comments?: