Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

set-oracle-data bot #190

Merged
merged 4 commits into from
Sep 30, 2021
Merged

set-oracle-data bot #190

merged 4 commits into from
Sep 30, 2021

Conversation

monstrobishi
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adds set-oracle-data bot

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Sep 28, 2021

Code Climate has analyzed commit 7d6a454 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #190 (7d6a454) into main (d5e4543) will increase coverage by 0.95%.
The diff coverage is 88.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   79.70%   80.66%   +0.95%     
==========================================
  Files          36       38       +2     
  Lines         616      693      +77     
  Branches       57       64       +7     
==========================================
+ Hits          491      559      +68     
- Misses        125      134       +9     
Impacted Files Coverage Δ
src/module.playground/bot/bot.ts 76.47% <76.47%> (ø)
src/module.playground/bot/oracle.bot.ts 91.07% <91.07%> (ø)
src/module.playground/_module.ts 93.02% <100.00%> (+0.16%) ⬆️
src/module.playground/setup/setup.oracle.ts 94.44% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e4543...7d6a454. Read the comment docs.

Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add a simple test to test the outcome of oracle price after block 250 or something.

src/module.playground/bot/oracle.bot.ts Show resolved Hide resolved
src/module.playground/bot/bot.ts Show resolved Hide resolved
@fuxingloh fuxingloh merged commit 03dbfda into main Sep 30, 2021
@fuxingloh fuxingloh deleted the monstrobishi/set-oracle-data-bot branch September 30, 2021 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants