Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

wallets/tokens/:id/send to support sending all token id with automatic confirmation #148

Merged
merged 6 commits into from
Aug 15, 2021

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Aug 15, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

  • wallets/tokens/:id/send to support sending all tokens with automatic confirmation. This removes the need to specify wait on Cypress tests for tokens.
  • this also brings better stability to tokens sending endpoint will lesser failures, verified with a 30x concurrent e2e test
  • UTXO is not supported yet

Which issue(s) does this PR fixes?:

Fixes #135
Fixed #149

@codeclimate
Copy link

codeclimate bot commented Aug 15, 2021

Code Climate has analyzed commit 16af795 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #148 (16af795) into main (a4986f9) will decrease coverage by 0.02%.
The diff coverage is 94.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   79.73%   79.70%   -0.03%     
==========================================
  Files          35       36       +1     
  Lines         597      616      +19     
  Branches       57       57              
==========================================
+ Hits          476      491      +15     
- Misses        121      125       +4     
Impacted Files Coverage Δ
packages/playground-api-client/src/api/wallet.ts 83.33% <75.00%> (-16.67%) ⬇️
src/module.api/wallet.controller.ts 97.67% <96.87%> (-0.11%) ⬇️
src/module.playground/_module.ts 92.85% <100.00%> (+0.17%) ⬆️
src/module.playground/setup/setup.utxo.ts 100.00% <100.00%> (ø)
src/module.playground/setup/setup.ts 92.50% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3387cfd...16af795. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review August 15, 2021 05:01
@fuxingloh fuxingloh force-pushed the fuxingloh/wallet-send-tokens branch from 526ac03 to 16af795 Compare August 15, 2021 05:14
@fuxingloh fuxingloh merged commit b4323e9 into main Aug 15, 2021
@fuxingloh fuxingloh deleted the fuxingloh/wallet-send-tokens branch August 15, 2021 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wallet/utxo/send with automatic wait /tokens/:tokenId/send sending other Token with auto waitForConfirmation
3 participants