Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JeffXiePL,
Here are some changes that I have made. This was really helpful. It has been great to have someone with fresh eyes to look at the code for the first time and put together a getting started set of notebooks.
I have streamlined and re-organised some of them. From the diffs, I am not sure it will be easy to see where things have gone from where you put them, but if you look ath them side by side, you can see that most of what you wrote is still there, but in a slightly different form.
Some of the things I have done:
sequence.gb
toU49845.gb
and same for the FASTA, to have more meaningful name)parse
and consistently used[0]
for the first element, I changed it to use the element directly. In general, if a list only has one element, it's better to store that element in a variable instead.If you have some time to keep working on this, I have left a couple of todo-manu comments in the Example_Restriction.ipynb notebook. You can have a go at those if you have the time. Otherwise, let me know and I will finish that.
Two important misconceptions that I noticed:
Dseq_Features.ipynb
, you mention that in theLocation
objects, thestart
andend
are 1-based and that intervals are closed. Instead,Location
objects are like python ranges. See the updated notebook.Dseq_Features.ipynb
notebook.Thanks again, and let me know if you will work on the TODOs in the Example_Restriction.ipynb notebook.