Up to date #1
Merged
Up to date #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results of operations way down nested pipelines were not being returned back. Keep a counter of pipelining nesting levels in order to infer whether we are in pipelining mode or not.
* First step in implementing streams * Correct key name * Id in time requires milliseconds * Create Streams class * Ensure data persists by adding a member * Sequence numbers * Sequence number with multiple items at the same time * xlen * Add ranges * streams -> stream * Extract Ids to new class * Rubocop * streams -> stream (really this time) * More xrange * A little more readable * Ensure messages are strings rather than symbols * COUNT option for xrange * List commands that are not yet supported * Correctly report some errors in xadd * Add xrevrange command * Raise error correctly * Deal with errors * Run Travis tests with Redis 5 server * Use redis-cli from installed Redis * Extract install of Redis 5 into a separate script * Remove pry (oops) * Travis didn't like this having execute permissions * Run the redis 5 install without requiring execute permissions * Allow fuzzy match between mock and real redis * Remove pry * Remove outdated Ruby version * Try Ruby version without patch number * Satisfy Rubocop * Redis 5 RC4 released * ... and update the travis file * Remove WIP (I added this file by accident) * Use gsub oon content of array if necessary * Use system supplied version of Redis again * First step in implementing streams * Correct key name * Id in time requires milliseconds * Create Streams class * Ensure data persists by adding a member * Sequence numbers * Sequence number with multiple items at the same time * xlen * Add ranges * streams -> stream * Extract Ids to new class * Rubocop * streams -> stream (really this time) * More xrange * A little more readable * Ensure messages are strings rather than symbols * COUNT option for xrange * List commands that are not yet supported * Correctly report some errors in xadd * Add xrevrange command * Raise error correctly * Deal with errors * Run Travis tests with Redis 5 server * Use redis-cli from installed Redis * Extract install of Redis 5 into a separate script * Remove pry (oops) * Travis didn't like this having execute permissions * Run the redis 5 install without requiring execute permissions * Allow fuzzy match between mock and real redis * Try Ruby version without patch number * Satisfy Rubocop * Redis 5 RC4 released * ... and update the travis file * Remove WIP (I added this file by accident) * Use gsub oon content of array if necessary * Use system supplied version of Redis again * Fix error with merge
* prefix keys with mock-redis-test to ensure cleared between runs * test for string conversion in get method
Ruby 2.3 reached EOL on March 31, 2019: https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/
Now that ownership has been transferred, update references accordingly.
This was missed in 83c90c1. While here, update the existing list of Rubies we do support.
* Make time command more aligned with redis * Fix rubocop complaints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.