Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting options after value thru props #79

Closed
wants to merge 1 commit into from

Conversation

farism
Copy link

@farism farism commented Mar 1, 2015

No description provided.

@JedWatson
Copy link
Owner

@farism can you explain this a bit please? looks like some important logic (e.g. if (newProps.value !== this.state.value)) has been removed.

@farism
Copy link
Author

farism commented Mar 9, 2015

From my understanding, that line of code is purely an optimization technique? The issue is that if options are set after value, then the component will not be properly updated (and label placeholder does not change). See #74

It's hard to tell without tests, but I don't believe the code is harmful. I don't think there is an issue with calling getStateFromValue each time props change. I've been using this fork in a few development projects the past couple weeks, but I cannot make any guarantees.

@farism
Copy link
Author

farism commented Mar 10, 2015

Just realized that #53 pretty much addresses the same issue :)

@dcousens
Copy link
Collaborator

dcousens commented May 7, 2015

Please rebase. Happy to merge this or #53

@dcousens dcousens closed this May 7, 2015
@dcousens dcousens reopened this May 7, 2015
@dcousens dcousens self-assigned this May 7, 2015
@dcousens dcousens added this to the 0.4.9 milestone May 7, 2015
@bruderstein bruderstein mentioned this pull request Jul 16, 2015
@Reggino
Copy link

Reggino commented Jul 20, 2015

I'm running into the same issue here. The fix looks good, thanks!

@dcousens dcousens assigned JedWatson and unassigned dcousens Jul 21, 2015
@dcousens dcousens closed this Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants