Fix onCreateOption is not always called for Creatable

[nikitaindik]

Issue: #3988

The issue is caused by "newOption" being recreated as a new object on every render.

[changeset-bot]

🦋 Changeset detected

Latest commit: 64ad645

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
react-select	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64ad645:

Sandbox	Source
react-codesandboxer-example	Configuration

[johannesleander]

Any update on plans to release this fix?

[bcalvignac]

Yes, I could use this fix, This is causing a new label XXX to appear as "Create XXX"

[sirjuan]

This issue (comparing with reference) sometimes causes onCreateOption to not be called. Instead onChange is called with select-option action and new option object as payload.

Merging and releasing this PR would fix it.

Edit: I tested this solution with our misbehaving component, and it indeed fixed it.

[laznic]

Could this fix get merged and published please? Thanks in advance!

[makker]

Would be greatly appreciated if this fix could be released! 🙏

[mika-kaki]

Looking forward for this fix. Thanks for your great work!

[bladey]

@JedWatson this looks good to me - pending your review.

[nikitaindik]

@bladey @JedWatson Hi guys! Do you think we can merge this? :)

[Methuselah96]

I've started a fork of react-select. Feel free to resubmit this PR on the fork and we can get it merged and released.

EDIT: 🎉 I've archived the fork now that we've got some momentum in this repo and Jed is involved again. Sorry for the disturbance!

[Methuselah96]

@nikitaindik Thanks for the PR!

1. Can you add a test?
2. My preference would actually be to change the behavior in Select.js to only memoize the options when they are strictly equal by changing isEqual(newProps.options, lastProps.options) to newProps.options === lastProps.options here (might as well change the other ones from isEqual to === as well). This allows people to use strict equality in their own onChange methods and not have to worry about the implementation detail that the memoization depends on an internal isEqual method. This memoization was introduced in Fix not focusing the selected value on menu open #3868 and I don't believe the memoization was essential to the fix in that PR.

[nikitaindik]

Hi @Methuselah96! I'll have some spare time during the weekend. I'll try to add a test see if I can resolve this isEqual thing.

[Methuselah96]

@nikitaindik Let me know if you don't have time to make the changes. I can do it myself if you don't have the time.

[nikitaindik]

Yep, sure. I'm still a little busy. Sorry. Please feel free to improve this PR.

…

On Tue, Dec 22, 2020 at 2:18 AM Nathan Bierema ***@***.***> wrote: @nikitaindik <https://github.com/nikitaindik> Let me know if you don't have time to make the changes. I can do it myself if you don't have the time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3990 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADZV2WR2JGSRFSVSP4UOYYLSV7XXDANCNFSM4LVREXJQ> .

Stale