Update MenuPlacer context usage to the new context API

[dpordomingo]

This solves #3916, and partially addresses #3703.

From React 16.3 the old Context API was deprecated and
it's rising warnings when runng in strict-mode.

[changeset-bot]

🦋 Changeset is good to go

Latest commit: ad608c8

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dpordomingo]

@JedWatson @gwyneplaine Let me please know if I missed any other thing in this PR, or if I should I address something.

[dpordomingo]

Is react-select maintained and opened to contributions from the community?

[mikemcalister]

Would love to see this get visibility to fix up this warning. Thanks for taking time for the fix @dpordomingo!

[wdelmas-shift]

@dpordomingo @gwyneplaine Do you have any updates on this PR?
I'll be really glad to see it merged.
Thanks guys :)

[marceliwac]

Hopefully won't be long now until @gwyneplaine approves this PR :)

[luanfelipecosta]

Any news guys?

[Andre2553]

Any news?

[Eric-Juquel]

finally is this issue fixed ? i really like react-select but those warnings are not so sexy ...

[GooBall]

Would love this round about now... 😂 not so great having all console logs blocked out for a good few scrolls on every page that has a react-select

[yardenroee]

how do I update my react-select version to solve this issue?

[bladey]

Sorry all, I'm aiming to get @JedWatson approve this as soon as possible.

[geoguide]

I hope they are okay.

[yardenroee]

@bladey is it safe to assume that if I copy the changes youve made in the files changed in this commit, I will be able to resolve the issue locally?

[marceliwac]

@yardenroee I suppose the safest way would be to checkout the latest version, and merge this branch in locally.

[yardenroee]

@yardenroee I suppose the safest way would be to checkout the latest version, and merge this branch in locally.

How do I do that exactly? lol
@marceliwac

[marceliwac]

How do I do that exactly? lol
@marceliwac

Normally the way you'd do it would follow the below points, but I looked closer and it looks like there are some build steps involved, so in the end you might be better of manually making the changes to the files given how it's just 1 file that needs to be changed.

1. Find the commit you want to use as a base (latest commit should do fine).
2. Clone the repository to local directory.
3. Iff the commit you wanted to use as base is not master, reset your local repository to that commit.
4. Merge the changes introduced in this PR.
5. Copy the actual react-select module (/packages/react-select) into your codebase.

@yardenroee

[bladey]

Thanks for the help @marceliwac, let us know if that doesn't work out for you @yardenroee.

[yardenroee]

@bladey after hard coding the changes, do I need to run any script? in order to implement the changes? because I have made the changes but it doesnt seem to change anything locally

[yardenroee]

Thanks for the help @marceliwac, let us know if that doesn't work out for you @yardenroee.

I changed the files inside my node_modules to the corresponding changes here, but the channges are not reflected. do you have any idea as to why this might happen?

[marceliwac]

Is there any progress on this issue? Has @JedWatson had a chance to review this PR yet?

[bladey]

Not yet @marceliwac, it will be done as soon as possible.

[geoguide]

Is there a reason this isn't getting considered? It's been 6 months and it affects a lot of people. Can I create a different PR to help with issues this might have?

[JedWatson]

Sorry for the delay everyone, my second daughter is 9 weeks old and it's been tough to stay on top of things.

Looks good, merging now and we'll have a release out asap!

[marceliwac]

@JedWatson Congrats and thanks for taking care of this eventually. Great job!

[cyonder]

I've re-installed this package through npm and my version is 3.1.0. And I confirm that I still have this issue. Hasn't it been released to npm?

[Methuselah96]

@cyonder No, the last release was on March 22, and this was merged on August 27.

[cyonder]

@Methuselah96 Thanks for quick reply. Has release date been decided?

[Methuselah96]

@cyonder No, the most recent significant communication from @JedWatson has been #3910 (comment). There has been no mention of a release date besides the occasional mention of "as soon as possible."

[jleider]

If @JedWatson does not have the time to continue to support this is there someone else at Thinkmill, Atlassian or any other community contributor who can take over the project while @JedWatson has other priorities?

[Methuselah96]

@jleider I'm not sure of the exact reasons why @JedWatson won't let someone else take over the project. One thing he said in his update comment was:

It's really tricky unless you've got all the context. Some things that seem safe and obvious aren't, so when we assess an issue or PR we're really starting from scratch reviewing it every time unless they come from someone we know has a lot of experience working on the project.

It could be that he doesn't think there's anyone else who understands the context of the project enough to take over.

[Methuselah96]

I've started a fork of react-select. This PR has been released in [email protected].

EDIT: 🎉 I've archived the fork now that we've got some momentum in this repo and Jed is involved again. Sorry for the disturbance!