Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prop to make "automatically focusing to the first option" optional #3010

Closed
wants to merge 1 commit into from
Closed

Add prop to make "automatically focusing to the first option" optional #3010

wants to merge 1 commit into from

Conversation

trkaplan
Copy link

@trkaplan trkaplan commented Sep 4, 2018

Related to #2653

This PR:

  • Add autoFocusFirstOption prop to make "automatically focusing to the first option" optional.
  • Update "Select" test.
  • Update snapshots

@sahibjotsaggu
Copy link
Contributor

sahibjotsaggu commented Sep 4, 2018 •
edited
Loading

From what I see in the code, this would auto focus on the first option if this prop is not provided, right (because it's set to true by default)?

@trkaplan
Copy link
Author

trkaplan commented Sep 4, 2018

Yes, since this was the default behaviour of the component.

@whitneymarkov
Copy link

Any word on when this will be merged?

@chamkank
Copy link

+1 this would be really useful

@trkaplan trkaplan mentioned this pull request Dec 1, 2018
Open
2 tasks
@mxl
Copy link

mxl commented Dec 10, 2018

Guys, could you merge this and make a new release?

@sarink
Copy link

sarink commented Jan 27, 2019

Why is this not getting merged?

@noahzweben
Copy link

+1 would love this!

@manvydasu
Copy link
Contributor

Still not merged???

@manvydasu manvydasu mentioned this pull request Jan 30, 2020
Closed
@rug1
Copy link

rug1 commented Jan 30, 2020

+1 on this please!

@rithpath
Copy link

Can you please merge this

@Matt-MSP
Copy link

+1 on this please!

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome pr/priority PRs that should be addressed sooner rather than later labels May 26, 2020
@bladey
Copy link
Contributor

bladey commented Jun 10, 2020

PR to be reviewed, duplicate of #3484

@bladey bladey mentioned this pull request Jun 10, 2020
Closed
@bladey
Copy link
Contributor

bladey commented Jun 10, 2020

Hi all,

Thanks for your contribution @trkaplan!

There are a number of pull requests adding this feature - I've since created an up to date PR - #4080, and closed similar pull requests.

If I've missed anything, please let me know.

Closing this PR in favor of #4080.

@bladey bladey closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuna1207 tuna1207 tuna1207 approved these changes

Assignees
No one assigned
Labels
pr/needs-review PRs that need to be reviewed to determine outcome pr/priority PRs that should be addressed sooner rather than later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.