[V2] Menu portal solution #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new prop `menuShouldPortal` - new component MenuPortal
treshugart
approved these changes
Mar 16, 2018
…tal to extrapolate styles to be exposed to getStyles and external styles prop
|
Hello everyone :) Any idea when this feature makes it to any of the alpha releases? I suppose 2.0.0-alpha.7 is still missing it |
|
@Rommero hoping to get |
|
Is there any way to add responsiveness to this feature? Maybe position top/bottom according to scroll position so the options don't go out of the page. |
|
Is there a known way of rendering the menu within a portal in v1? |
|
This issue is appearing again in v 2.1.1 |
|
@JedWatson @jossmac, as @pratham4 mentioned- it doesn't seem to be in a portal anymore (version: Any ideas why this might of reverted? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
menuPortalTargetMenuPortalRef #2398
overflow: hidden;example can be found at react-select/tests