Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use innerRef prop instead of ref to avoid warning #2416

Closed
wants to merge 1 commit into from

Conversation

meriadec
Copy link

@meriadec meriadec commented Mar 5, 2018

2018-03-05_1841x150

relatable: #2181

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.973% when pulling 9262af9 on meriadec:master into c9d0273 on JedWatson:master.

@sungwoncho
Copy link

sungwoncho commented Mar 17, 2018

This change will break apps that are relying on ref prop. How do you feel about deprecating ref while adding innerRef rather than removing ref altogether?

@JedWatson
Copy link
Owner

Thanks for the PR @meriadec

I agree with @sungwoncho - we can't make this change without a major bump, and I'm inclined to implement the new ref forwarding from React 16.3 as the solution to this. In the meantime, we could add a selectRef prop to get rid of the warning if somebody wants to PR that.

@JedWatson JedWatson closed this Apr 14, 2018
@Dem0n3D
Copy link

Dem0n3D commented Apr 25, 2018

@JedWatson, please, do something with this warning already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants