Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/numeric multi select #2086

Merged
merged 5 commits into from
Oct 25, 2017
Merged

Fix/numeric multi select #2086

merged 5 commits into from
Oct 25, 2017

Conversation

gwyneplaine
Copy link
Collaborator

@gwyneplaine gwyneplaine commented Oct 23, 2017

Added string coercion to condition in expandvalue()
Fixes the bug referenced in #1600 and in #1476

Edmond Pruteanu and others added 3 commits March 12, 2017 02:56
Selected options weren’t being added to the input in Multi-Select mode
for Numeric Values
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 92.901% when pulling b560516 on fix/numeric-multi-select into b6fd3e7 on master.

@gwyneplaine gwyneplaine force-pushed the fix/numeric-multi-select branch from b560516 to a0965e0 Compare October 23, 2017 06:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.879% when pulling a0965e0 on fix/numeric-multi-select into b6fd3e7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.879% when pulling bdcb33f on fix/numeric-multi-select into b6fd3e7 on master.

@gwyneplaine gwyneplaine merged commit ca09183 into master Oct 25, 2017
@gwyneplaine gwyneplaine deleted the fix/numeric-multi-select branch October 25, 2017 05:54
@tauren
Copy link

tauren commented Oct 26, 2017

@gwyneplaine Any chance we can get a release cut with this in it?

@gwyneplaine
Copy link
Collaborator Author

@tauren yup, I've talked to @JedWatson , and the intention is to get a new release cut within the next couple of days. Stay tuned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants