Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing css states to be scoped with Select selector, closes #1951. #2000

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Fixing css states to be scoped with Select selector, closes #1951. #2000

merged 1 commit into from
Sep 14, 2017

Conversation

agirton
Copy link
Collaborator

@agirton agirton commented Sep 13, 2017

Ran this locally and compared each of the demos against the live version
and saw no differences.

@agirton
Fixing css states to be scoped with Select selector, closes JedWatson…
b5a17bb 
…#1951.

Ran this locally and compared each of the demos against the live version
and saw no differences.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.994% when pulling b5a17bb on agirton:bugfix/1951-css-state-selector-scoping into 9af79b7 on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks @agirton, and @csswizardry for the detailed issue!

@JedWatson JedWatson merged commit 49b12b0 into JedWatson:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JedWatson JedWatson JedWatson approved these changes

@gwyneplaine gwyneplaine Awaiting requested review from gwyneplaine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agirton @coveralls @JedWatson