Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing confusing doc wording #1588

Closed
wants to merge 1 commit into from

Conversation

weexpectedTHIS
Copy link

Definition of onChange handler parameter says it returns the newValue but it actually returns the newOption (which is a hash)

Definition of onChange handler parameter says it returns the newValue but it actually returns the newOption (which is a hash)
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.9%) to 87.776% when pulling 5a695ba on weexpectedTHIS:patch-1 into 2249f26 on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks @weexpectedTHIS!

Unfortunately it's conflicted with the updated formatting in the Readme - would like to update your PR? otherwise I'm happy to copy this across myself.

@JedWatson JedWatson closed this in 97af36a Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants