Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label for multiselect #1404

Closed
wants to merge 2 commits into from
Closed

fix label for multiselect #1404

wants to merge 2 commits into from

Conversation

SVITY
Copy link

@SVITY SVITY commented Dec 1, 2016

In Firefox labels with several words are shown into 2 lines instead 1 line http://take.ms/J3hs7
I added white-space into multi.scss and ran build.
If you want I can create pull request without build.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.308% when pulling 9822211 on SVITY:master into ef3a468 on JedWatson:master.

@protron
Copy link

protron commented Dec 1, 2016

Isn't this already fixed in master by #1300 ?

@SVITY
Copy link
Author

SVITY commented Dec 1, 2016

@protron Yes, it fixed. Probably I use not the last version of react-select, without this fix.
Just I wanted to contribute to the great react component.

Thanks

@SVITY SVITY closed this Dec 1, 2016
@SVITY
Copy link
Author

SVITY commented Dec 5, 2016

#1300 it fixed the bug. But the last master commit does not have these changes. How is it possible?
Less directory has changes, but nothing into dist directory.

@SVITY SVITY reopened this Dec 5, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.308% when pulling 9822211 on SVITY:master into ef3a468 on JedWatson:master.

@gwyneplaine
Copy link
Collaborator

@SVITY you need to run the build script npm run build to compile the changes in the less file to dist

Issue closed, as bug fixed in #1300 (merged into master)

@gwyneplaine gwyneplaine closed this Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants