Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Async.js #1209

Closed
Closed

Conversation

shashikanthgadgay
Copy link

Added an empty array when the options in cacheResult is undefined.
Fix for Async.js

Added an empty array when the cache result is undefined
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.19% when pulling 66bc467 on shashikanthgadgay:patch-1 into f723189 on JedWatson:master.

@bvaughn
Copy link
Collaborator

bvaughn commented Sep 13, 2016

Hey @shashikanthgadgay. Thanks for the PR! 😁

This issue was fixed by another PR though, FWIW. master no longer has this problem:

react-select/src/Async.js

Lines 130 to 134 in 8362f8b

if (cacheResult && Array.isArray(cacheResult.options)) {
return this.setState({
options: cacheResult.options,
});
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants