-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an optional instance id property #1105
Added an optional instance id property #1105
Conversation
This will allow synchronization of component id’s on both the server and the client.
[edit] Should close #1104 |
Good solution! I don't think you need to add the instanceId to the state though. Defaulting to this in the this._instancePrefix = 'react-select-' + (this.props.instanceId || ++instanceId) + '-'; Did you link to the wrong "should close" issue number btw? |
I've updated my solution @JedWatson. Thanks for the suggestion. |
We're also running into this. Thanks for working out a solution! |
Any word on this? |
…er-Side-rendering
Thanks for that @JevinAnderson, looks good now! Sorry for the delayed merge. |
@JedWatson What is your workflow for rebuilding the dist files? I noticed that master is updated with this change, but if I do an Thanks! |
@mverderese I'm about to publish an rc with this fix in it, it should be fine if you update the dependency in your project to that. |
I'm still getting
Am I doing something wrong? |
This will allow synchronization of component id’s on both the server
and the client.