Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newOptionCreator not working as intended. #658

Closed
bIgBV opened this issue Dec 10, 2015 · 7 comments
Closed

newOptionCreator not working as intended. #658

bIgBV opened this issue Dec 10, 2015 · 7 comments

Comments

@bIgBV
Copy link

bIgBV commented Dec 10, 2015

I am facing this issue when trying to add a new value through the input box.

When allowCreate is set to true, the function passed as the newOptionCreator prop is not being called.

For example:

....
    optionCreator: function (value) {
        console.log(value); // This line isn't reached.
    },

    render: function() {
        return (
            <Select multi={true}
                    allowCreate={true}
                    newOptionCreator={this.optionCreator} />
        );
    }

...
@bIgBV
Copy link
Author

bIgBV commented Dec 10, 2015

Something that I noticed was that the prop wasn't being used anywhere in select.js. If so does this mean it still isn't implemented ?

@hsrobflavorus
Copy link

Confirmed, this isn't being used anywhere in the code, and doesn't appear to have any affect on the selected results.

@asazernik
Copy link

@bIgBV In case you haven't seen the linked #658 - this is functionality that hasn't yet been implemented in the 1.0 rewrite. Use the latest 0.9.x version instead.

@bIgBV
Copy link
Author

bIgBV commented Jan 16, 2016

Yeah, we ended up moving to the previous version for that feature. Thanks !
On 15 Jan 2016 4:12 a.m., "Asa Zernik" [email protected] wrote:

@bIgBV https://github.com/bigBV In case you haven't seen the linked #658
#658 - this is
functionality that hasn't yet been implemented in the 1.0 rewrite. Use the
latest 0.9.x version instead.


Reply to this email directly or view it on GitHub
#658 (comment)
.

@f2net
Copy link

f2net commented Apr 29, 2016

Is there any plan to add this feature in v.1 beta 13?
Thank you

@bvaughn
Copy link
Collaborator

bvaughn commented Sep 3, 2016

By the way, I believe PR #1187 should resolve this issue. Please feel free top give the branch a spin and let me know if you have any concerns or other feedback. 😄

@bvaughn
Copy link
Collaborator

bvaughn commented Sep 4, 2016

This issue no longer exists in the 1.x code (as of PR #1187) and so I'm going to close it!

Look for an updated RC with this functionality soon. 😎

@bvaughn bvaughn closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants