-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0.rc10 async "caching" error #2009
Comments
Some more detail: it seems like part of the issue relates to the "intelligent caching" of input strings that have already been fetched. When the user types faster than the fetches can complete, it seems like "no options" are being cached for the intermediate search strings. |
Ah, it seems like the original issue is due to the component hitting the Github API rate limit 😄 oops. Regardless, I think there is room for optimization here: Let's say the user types @JedWatson what do you think about moving lines 104-106 outside the |
A related issue occurs when handling paginated endpoints: Let's say I do a search for Then, I clear the input and search for This normally would be fine, but with paginated endpoints, the options for The solution suggested above should fix it, but do you think it would also be good to set |
Addresses JedWatson#2009. There is a WIP test -- I can't figure out how to simulate the exact scenario that this patch fixes in the test. The current test returns positive even without my change. Suggestions would be appreciated -- thanks!
Thanks for the comprehensive issue report and fix, @timhwang21 Closed by #2012 |
Bug: When user types faster than responses can finish, "intermediary" search queries do not ever get attempted.
Example:
I type "asdf" while throttling the network. Queries are fired for "a", "as", "asd", and "asdf". However, when I start deleting letters, the queries for the first three search strings are never attempted. Note the placeholder text says 'Type to search' rather than 'No results.'
The text was updated successfully, but these errors were encountered: