Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production build should not include proptypes definitions #1882

Closed
jochenberger opened this issue Jul 20, 2017 · 1 comment
Closed

Production build should not include proptypes definitions #1882

jochenberger opened this issue Jul 20, 2017 · 1 comment

Comments

@jochenberger
Copy link
Contributor

jochenberger commented Jul 20, 2017

The proptypes specifications should be stripped from the production build.
The definitions could be wrapped in if (process.env.NODE_ENV !== 'production') clauses, but that won't get replaced in the browserify bundling step.
That probably makes it a feature that could go into https://github.com/JedWatson/react-component-gulp-tasks, but it might be a better idea to switch to Webpack or even Rollup on the long run. @JedWatson, any advice how this should be solved?

@jochenberger
Copy link
Contributor Author

Since the build uses rollup now, it might be a good time to revisit this.

jochenberger added a commit to jochenberger/react-select that referenced this issue Sep 14, 2017
jochenberger added a commit to jochenberger/react-select that referenced this issue Sep 14, 2017
JedWatson added a commit that referenced this issue Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant