Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown props with React 15.2 #1073

Closed
mikecousins opened this issue Jul 6, 2016 · 7 comments
Closed

Unknown props with React 15.2 #1073

mikecousins opened this issue Jul 6, 2016 · 7 comments

Comments

@mikecousins
Copy link

mikecousins commented Jul 6, 2016

react-select now throws a warning when using React 15.2:

warning.js:44 Warning: Unknown prop `minWidth` on <input> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in input (created by AutosizeInput)
    in div (created by AutosizeInput)
    in AutosizeInput (created by Select)
    in div (created by Select)
    in div (created by Select)
    in Select (created by Async)
    in Async (created by ComposePage)
    in div (created by ComposePage)
    in div (created by ComposePage)
    in div (created by ComposePage)
    in div (created by ComposePage)
    in ComposePage (created by RouterContext)

The React team says this needs to be fixed as it will break in the next major release: facebook/react#7152 (comment)

@reactima
Copy link

reactima commented Jul 9, 2016

Quite disappointed by React 15.2. Has to make a deep dive into both react-select and redux-form
https://github.com/erikras/redux-form/releases/tag/v6.0.0-rc.2

Simple fix by adding .input didn't help

<Select placeholder="bla-bla-bla" options={props.userTypes} searchable={true} clearable={true} {...props.input} onBlur={()=>{}} />

@JedWatson
Copy link
Owner

I've fixed this upstream and updated react-input-autosize, which should fix this. Will get a new npm release of react-select published as soon as I've completed testing & changelog for the fixes since the last release.

@Borislav-ARC
Copy link

Borislav-ARC commented Jul 12, 2016

it's not good solving, it can work like temporary fixing. we are waiting for right solving

@morsdyce
Copy link

morsdyce commented Aug 7, 2016

Any chance of getting this fix in the 0.9 branch?

@Stupidism
Copy link

Stupidism commented Aug 23, 2016

Please fix 0.9 branch for users are using allowCreate feature


In the source code

var Input = require('react-input-autosize');
...
input = <Input minWidth="5" />;

Found solution: npm i --save react-input-autosize
@morsdyce

nkcmr added a commit to cloudflare/cf-ui that referenced this issue Oct 31, 2016
@skovhus
Copy link

skovhus commented Mar 9, 2017

Any reason why this wasn't fixed for the 0.9 branch? Seems like a rather small thing to do... Any incompatabilities? Or just need help @JedWatson?

Suggested fix above doesn't work with yarn.

@mnieber
Copy link

mnieber commented Aug 18, 2017

I moved to react-selectize (not to critize react-select, which is great, but this fixed my immediate problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants