Skip to content

Commit

Permalink
18538 Resulting Business Name and Type component (WIP) (bcgov#591)
Browse files Browse the repository at this point in the history
* PR (TODO fix unit tests)

* Added unit tests for numbered am

* Fixed test case and update from comments

* Added additional test case

* Updated unit test formatting.

* Updated package.json

* Added bullet points for numberd AML

* Fixed test cases
  • Loading branch information
jamespaologarcia authored and JazzarKarim committed Feb 23, 2024
1 parent d949e22 commit 21e1113
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 5 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "5.6.9",
"version": "5.6.10",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand Down
15 changes: 15 additions & 0 deletions src/components/common/NameRequestInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,20 @@
</v-row>
</div>
</template>
<template v-else-if="isAmalgamationFiling && !getNameRequestNumber">
<!-- Numbered Amalgamation-->
<div class="section-container">
<v-row
id="numbered-amalgamation-info"
no-gutters
>
<v-col
cols="12"
sm="3"
class="pr-4"
>
<label>Resulting Business Name</label>
</v-col>

<!-- display other numbered company info -->
<template v-else>
Expand Down Expand Up @@ -278,6 +292,7 @@ export default class NameRequestInfo extends Mixins(CommonMixin, DateMixin) {
@Getter(useStore) isTypeBcCcc!: boolean
@Getter(useStore) isTypeBcUlcCompany!: boolean
@Getter(useStore) isTypeSoleProp: boolean
@Getter(useStore) isAmalgamationFiling!: boolean
get numberedCompanySuffix (): string {
if (this.isTypeBcCcc) return 'B.C. COMMUNITY CONTRIBUTION COMPANY'
Expand Down
6 changes: 4 additions & 2 deletions src/views/AmalgamationRegular/Information.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
helpLabel="Help with Business Type"
>
<template #content>
[*** TODO: help text component ***]
<BusinessTypeHelp />
</template>
</ExpandableHelp>

Expand All @@ -50,13 +50,15 @@ import { DefineCompanyIF } from '@/interfaces'
import { CommonMixin } from '@/mixins'
import { RouteNames } from '@/enums'
import { ExpandableHelp } from '@bcrs-shared-components/expandable-help'
import AmalgamatingBusinesses from '@/components/Amalgamation/AmalgamatingBusinesses.vue'
import BusinessTypeHelp from '@/components/Amalgamation/BusinessTypeHelp.vue'
import NameRequestInfo from '@/components/common/NameRequestInfo.vue'
import NameTranslations from '@/components/common/NameTranslations.vue'
import AmalgamatingBusinesses from '@/components/Amalgamation/AmalgamatingBusinesses.vue'
@Component({
components: {
AmalgamatingBusinesses,
BusinessTypeHelp,
ExpandableHelp,
NameRequestInfo,
NameTranslations
Expand Down

0 comments on commit 21e1113

Please sign in to comment.