[MIG] [18.0] import_export_templating: migrated module #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivedi-Vacha-SerpentCS
requested changes
Oct 23, 2024
There was a problem hiding this comment.
@ShwetaSerpentCS header-logo.png and index.html file requires your attention.
educate the developer too about the same.
| @@ -374,7 +274,10 @@ def import_data(self): | |||
| for x in sheet.row_values(rownum) | |||
| ] | |||
| model = self.ir_model.model | |||
| print("\n\n model", model) | |||
There was a problem hiding this comment.
Remove Print statements
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| { | |||
| "name": "Import / Export Templating", | |||
| "version": "17.0.1.0.0", | |||
| "version": "18.0.1.0.0", | |||
| "license": "LGPL-3", | |||
| "author": "Serpent Consulting Services Pvt. Ltd.", | |||
| "maintainer": "Serpent Consulting Services Pvt. Ltd.", | |||
There was a problem hiding this comment.
summary should not be blank.
also company website link should be https
|
Testing is assigned to devraj |
Trivedi-Vacha-SerpentCS
approved these changes
Oct 25, 2024
|
@ShwetaSerpentCS Icon should not be like this, the module is for data upload, not for any transportation(import/export). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsible : Jayram