[14.0] [MIG] hr_applicant: Migrated the module in v14. #522
Conversation
Chandresh-SerpentCS
commented
Nov 18, 2020
Chandresh-SerpentCS
commented
- Module developed by Pragati Patel. (Assigned by Yogesh Mahera)
|
@YogeshMahera-SerpentCS Please review the PR. Thanks. |
hr_applicant/LICENSE/LICENSE
Outdated
| @@ -0,0 +1,16 @@ | |||
| OpenERP, Open Source Management Solution | |||
| Copyright (C) 2011-Today Serpent Consulting Services Pvt. Ltd. | |||
hr_applicant/README.rst
Outdated
| @@ -0,0 +1,29 @@ | |||
| ================== | |||
| HR Applicant | |||
| ================== | |||
| "test": [], | ||
| "installable": True, | ||
| "auto_install": False, | ||
| "application": True, |
There was a problem hiding this comment.
We may remove "demo", "test" attributes as not any value has been assigned to it. Here, "auto_install" is by default False, so we may remove it.
hr_applicant/models/training.py
Outdated
| and datetime.datetime.strftime( | ||
| rec.training_start_date, DEFAULT_SERVER_DATE_FORMAT | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Here, We may optimise this as this version may accept the comparison/assignment directly by datetime object.
hr_applicant/models/training.py
Outdated
| if not rec.training_attendees: | ||
| raise ValidationError( | ||
| _("Training Attendees should not be Zero!")) | ||
| rec.write({"state": "approved"}) |
There was a problem hiding this comment.
We can avoid this type of pattern for assignment rather we can use rec.state="approved".
hr_applicant/models/training.py
Outdated
| raise ValidationError( | ||
| _("Training Attendees should not be Zero!")) | ||
| rec.write({"state": "approved"}) | ||
| return True |
There was a problem hiding this comment.
Here, may no need to return True. Please check for this.
hr_applicant/models/training.py
Outdated
| ) | ||
| ) | ||
| self.write({"state": "cancel"}) | ||
| return True |
There was a problem hiding this comment.
Same as above, we can change the all state assignment and please check for return True if we can remove it.
hr_applicant/models/training.py
Outdated
| for rec in self: | ||
| if str(rec.training_start_date) < datetime.datetime.now().strftime( | ||
| DEFAULT_SERVER_DATE_FORMAT | ||
| ): |
There was a problem hiding this comment.
Here, we may compare datetime object directly, please check if we can remove string conversion , we may use fields.Datetime.now() rather using python lib datetime.
| # See LICENSE file for full copyright and licensing details. | ||
|
|
||
| from odoo import models, fields, api | ||
| import datetime |
There was a problem hiding this comment.
Remove import datetime if not used elsewhere.
| @@ -0,0 +1,55 @@ | |||
| # See LICENSE file for full copyright and licensing details. | |||
|
|
|||
| from odoo import models, fields, api | |||
There was a problem hiding this comment.
Import should be in alphabetical order.
| for rec in self: | ||
| class_obj = self.env["training.class"] | ||
| applicant = self.env["hr.applicant"].search( | ||
| [("id", "=", self._context.get("active_id"))]) |
There was a problem hiding this comment.
Here, we can define self.env[''] object outside the loop.
|
@ForamSerpentCS I solved the comments, Can you please review it? |
