[14.0] [MIG] sale_report_hide_price: Module migrated in v14. #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Chandresh-SerpentCS
commented
Nov 10, 2020
Chandresh-SerpentCS
commented
- Module developed by Pragati Patel. (Assigned by Yogesh Mahera)
[IMP]Improved code in js. [IMP]Js Travis Fix. [IMP]Js Travis Fix. [IMP]Js Travis Fix.
|
@YogeshMahera-SerpentCS Please review the PR. Thanks. |
24 tasks
| @@ -0,0 +1,16 @@ | |||
| OpenERP, Open Source Management Solution | |||
| Copyright (C) 2004-2010 OpenERP SA (<http://www.openerp.com>) | |||
| Copyright (C) 2011-Today Serpent Consulting Services Pvt. Ltd. (<http://www.serpentcs.com>). | |||
| "Show Discount", | ||
| help="If checked, you can see the discount" | ||
| " in report of Sales Order/Quotation.", | ||
| ) |
There was a problem hiding this comment.
@ForamSerpentCS We should have this feature linked with Security groups.
These fields should be seen by ACCOUNT Manager (or top account group).
There was a problem hiding this comment.
Yes we may, If we can have security groups for it, then we can manage this feature directly applying field security in template.
|
@ForamSerpentCS please review the code. |
ForamSerpentCS
approved these changes
Dec 10, 2020
|
@ForamSerpentCS could you test? |
It contains syntax error. Will make it updated. |
|
Let me know when its ready |
Have tested it, It's now ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.