This repository has been archived by the owner on May 11, 2023. It is now read-only.
Jax utils py tree refactor #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create kroncker_linear_operator.py
Merging Kronecker work to Equinox branch since it restructures class properties (would have to do this again otherwise).
Stage two: Abstract out more properties / methods as attributes to make it possible to build LinearOperators from defining a mat_mul, shape and dtype, *args, **kwargs.
thomaspinder
suggested changes
Mar 14, 2023
There was a problem hiding this comment.
Overall looks good. Before approving, I would ideally like to see two things:
- More documentation would be helpful. A simple notebook demonstrating the functionality of JaxLinOp and some more informative docstrings would be sufficient for now.
- Coverage - it looks like a report is being uploaded to codecov, but I don't see the percentage anywhere.
|
|
||
| if not isinstance(size, int): | ||
| raise ValueError(f"`length` must be an integer, but `length = {size}`.") | ||
| if not isinstance(shape, tuple): |
There was a problem hiding this comment.
Do we not want it be an Iterable? I'd have thought a list was valid here.
There was a problem hiding this comment.
Will open issue for this.
|
|
||
| # TODO: Generalise to non-square matrices. | ||
| # TODO: Generalise to non-square matrices. |
There was a problem hiding this comment.
Can we either act on TODOs or open issues for them please
There was a problem hiding this comment.
Will open issue for these.
| @@ -175,7 +178,8 @@ def from_dense(cls, dense: Float[Array, "N N"]) -> ZeroLinearOperator: | |||
| """ | |||
|
|
|||
| # TODO: check shapes. | |||
There was a problem hiding this comment.
Same comment as above re. TODOs
This was referenced Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the base class inheritance to
simple-pytree.We move
shapeanddtypeto attributes of the dataclass, and ensure that dtype can be passed to each LinOps__init__to override the dtype of the linear operator.