Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper edits for JOSS #75

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

theorashid
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): paper

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Hey Thomas and Daniel,

This is for openjournals/joss-reviews#4455. There was a broken reference and a typo. Also, you mentioned you wanted the title changed to GPJax: A didactic Gaussian Process framework in Jax. Now is your chance to add it (although personally I think "didactic" only makes the title confusing).

A couple of other points, which I'm happy for an open discussion:

  • Are there no GPs packages in R? How do R users get by?
  • Is it worth mentioning that some PPLs have submodules for GPs which are commonly used, e.g pymc. Feel free to convince me these are really limited compared to the purpose-built libraries
  • Is it worth mentioning the other jax-based GP packages: tinygp and bayesnewton. bayesnewton has also been used by the Aalto team for graph GPs (in jax). tinygp interests me because it integrates with numpyro, which I find much better than tfp.

Best,

Theo

@thomaspinder
Copy link
Collaborator

Hi @theorashid. I'm unsure if you can see my update to your PR, but I have responded to your comments and updated the paper accordingly here.

@theorashid
Copy link
Contributor Author

Great. Are you able to merge these to master? Then I will remake the pdf using the bot and read through it again

@thomaspinder thomaspinder merged commit 4a813c9 into JaxGaussianProcesses:master Jun 15, 2022
@thomaspinder
Copy link
Collaborator

Great. Are you able to merge these to master? Then I will remake the pdf using the bot and read through it again

Done!

@theorashid
Copy link
Contributor Author

It doesn't seem to have merged your updates

@thomaspinder
Copy link
Collaborator

My bad. Should be merged now.

@theorashid theorashid deleted the paper-edit branch June 15, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants