Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional solver_algorithm parameter to sample_approx #478

Merged

Conversation

theorashid
Copy link
Contributor

Checklist

  • I've formatted the new code by running hatch run dev:format before committing.
  • I've added tests for new code.
  • I've added docstrings for the new code.

Description

  • Added an optional solver_algorithm parameter to the ConjugatePosterior.sample_approx method for solving the inverse of the covariance matrix.
  • Updated the test_conjugate_posterior_sample_approx test function to include the solver_algorithm parameter.

Issue Number: #475. Related issue #381.

…rior` class for solving the inverse of the covariance matrix.

- Updated the `test_conjugate_posterior_sample_approx` test function to include the `solver_algorithm` parameter.
@theorashid theorashid changed the title optional solver_algorithm parameter to the sample_approx optional solver_algorithm parameter to sample_approx Sep 16, 2024
Copy link
Collaborator

@thomaspinder thomaspinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you please 1) remove the commented line, and 2) bump the version in __about__.py the patch version?

tests/test_gps.py Outdated Show resolved Hide resolved
@thomaspinder thomaspinder merged commit 6eaab4a into JaxGaussianProcesses:main Sep 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants