Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Adding tagged parameters and updated notebooks #452

Merged
merged 14 commits into from
Jun 26, 2024

Conversation

thomaspinder
Copy link
Collaborator

Type of changes

  • Bug fix
  • [X ] New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've formatted the new code by running poetry run pre-commit run --all-files --show-diff-on-failure before committing.
  • I've added tests for new code.
  • I've added docstrings for the new code.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

Issue Number: N/A

@thomaspinder thomaspinder requested a review from frazane June 6, 2024 15:00
@thomaspinder thomaspinder changed the title Adding tagged parameters and updated notebooks [DRAFT] Adding tagged parameters and updated notebooks Jun 6, 2024
docs/examples/intro_to_kernels.py Outdated Show resolved Hide resolved
gpjax/parameters.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
gpjax/parameters.py Show resolved Hide resolved
@@ -106,7 +106,7 @@ def __call__( # TODO not consistent with general kernel interface
*,
S,
**kwargs,
) -> Float[Array, ""]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "N N"

@thomaspinder thomaspinder merged commit c359936 into flax-backend-normalclasses Jun 26, 2024
12 checks passed
@thomaspinder thomaspinder deleted the tagged-params branch June 26, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants