Namespace cleanup #408
Merged
Namespace cleanup #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st--
reviewed
Nov 10, 2023
st--
reviewed
Nov 10, 2023
| integrators, | ||
| ) | ||
| from gpjax.base import ( | ||
| Module, |
There was a problem hiding this comment.
It's probably better to be consistent but gpjax.Module (and perhaps the param_field) is the one thing I would've just kept in the "top-level" namespace.
Edit: actually, Dataset is in the top-level namespace as well so maybe that's an argument to keep Module, too?
There was a problem hiding this comment.
Resolved in forthcoming commit
st--
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Looks good to me, and overall I'm very happy with these changes - though I would
- suggest (but not bother arguing about) keeping
Moduleandparam_fieldin the top-level name-space - strongly suggest (and be willing to argue) that this is breaking and bump the version to 0.8.0 to follow semantic versioning
- there's pending merge conflicts that I've not reviewed
Co-authored-by: st-- <[email protected]> Signed-off-by: Thomas Pinder <[email protected]>
…PJax into namespace_cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failurebefore committing.Description
This PR cleans up the package's namespace, as per Slack discussions.
Issue Number: N/A