don't depend on docs.javacord.org #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fallback javadoc.io docs to use if docs.javacord.org doesn't work use ci.javacord.org for getting the version
Vampire
requested changes
Oct 14, 2020
There was a problem hiding this comment.
docs.javacord.org and ci.javacord.org are the same server.
Actually docs. is just a thin wrapper over ci. to provide nice URLs for browsing the build artifacts from ci..
So if one is down, probability is high that both are down.
I'd suggest in the latest version finder you keep the old source for version from docs. and if it does not work,
fall back to looking inside https://repo1.maven.org/maven2/org/javacord/javacord/maven-metadata.xml which should give you the latest released version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fallback javadoc.io docs to use if docs.javacord.org doesn't work
use ci.javacord.org for getting the version