Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Implemented FuzzyWuzzy as search engine, allowing typos in !docs command [postponed] #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🚧 Implemented FuzzyWuzzy as search engine, allowing typos in !docs command [postponed] #25

wants to merge 1 commit into from

Conversation

burdoto
Copy link

@burdoto burdoto commented Nov 13, 2018

NOTE: This version of FuzzyWuzzy is under GPL License, but this will change in Version 2.0.0, which is currently WIP.
If this is requested, I can change this PR to 2.0.0 as soon as it is released.

@comroid-commit
Implemented FuzzyWuzzy as search engine, allowing typos in !docs command
b23b9dc 
NOTE: This version of FuzzyWuzzy is under GPL License, but this will change in Version 2.0.0, which is currently WIP.
If this is requested, I can change this PR to 2.0.0 as soon as it is released.
@Vampire
Copy link
Member

Vampire commented Nov 25, 2018

I thought xdrop/fuzzywuzzy#44 is necessary for this?
Anyway, as long as it is releasing under GPL, this cannot work, we would infringing their copyright unless we release the bot under GPL too which it is not currenlty.
So as long as they don't release a version with a licence compatible with ASL, this PR cannot be accepted and then also only with that version.

@Vampire Vampire changed the title Implemented FuzzyWuzzy as search engine, allowing typos in !docs command :wip: Implemented FuzzyWuzzy as search engine, allowing typos in !docs command Nov 25, 2018
@Vampire Vampire changed the title :wip: Implemented FuzzyWuzzy as search engine, allowing typos in !docs command 🚧 Implemented FuzzyWuzzy as search engine, allowing typos in !docs command Nov 25, 2018
@burdoto
Copy link
Author

burdoto commented Nov 27, 2018

Yes, # 44 was intended for this particular use.
We are currently working on getting non-gpl algorithms to fuzzywuzzy and plan on completing this around Jan19.
This pr can be left open and I will change it as soon as there is a non-gpl usable variant.

@burdoto burdoto changed the title 🚧 Implemented FuzzyWuzzy as search engine, allowing typos in !docs command 🚧 Implemented FuzzyWuzzy as search engine, allowing typos in !docs command [postponed] Nov 27, 2018
@Saladoc Saladoc added the on hold Blocked by external dependencies / discussion, will be picked up later. label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold Blocked by external dependencies / discussion, will be picked up later.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@burdoto @Vampire @Saladoc @comroid-commit