Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the !wiki command to enable searching the wiki. #11

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Expand the !wiki command to enable searching the wiki. #11

merged 1 commit into from
Oct 31, 2018

Conversation

Saladoc
Copy link
Member

@Saladoc Saladoc commented Sep 11, 2018

Supports title-only search, default search (titles and keywords) and full search (titles, keywords and content)

wiki-multiple-results
wiki-single-result

@Saladoc Saladoc added the enhancement New feature or request label Oct 23, 2018
Vampire
Vampire requested changes Oct 29, 2018
View reviewed changes
Copy link
Member

@Vampire Vampire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look over it, looks good so far, besides the comments I added. :-)

src/main/java/org/javacord/bot/util/wiki/parser/WikiParser.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/util/wiki/parser/WikiParser.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/util/wiki/parser/WikiParser.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/util/wiki/parser/WikiParser.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/commands/WikiCommand.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/commands/WikiCommand.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/commands/WikiCommand.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/commands/WikiCommand.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/commands/WikiCommand.java Outdated Show resolved Hide resolved
src/main/java/org/javacord/bot/commands/WikiCommand.java Outdated Show resolved Hide resolved
@Saladoc Saladoc force-pushed the wiki-search branch 2 times, most recently from 00e00fa to e3e8132 Compare October 31, 2018 03:09
@Saladoc Saladoc requested review from Vampire and removed request for Bastian October 31, 2018 03:30
@Saladoc Saladoc merged commit 70469fb into Javacord:master Oct 31, 2018
Vampire
Vampire reviewed Oct 31, 2018
View reviewed changes
Copy link
Member

@Vampire Vampire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, now you were too fast in merging.
What do you think about those two last polishing points?

src/main/java/org/javacord/bot/commands/WikiCommand.java Show resolved Hide resolved
src/main/java/org/javacord/bot/commands/WikiCommand.java Show resolved Hide resolved
@Saladoc Saladoc deleted the wiki-search branch December 6, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bastian Bastian Bastian left review comments

@Vampire Vampire Vampire approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saladoc @Vampire @Bastian