New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DisposeAsync with scopes and hosts #99

Merged

jeremydmiller merged 1 commit into JasperFx:master from ArturDorochowicz:async

Sep 25, 2024

Contributor

ArturDorochowicz commented Sep 24, 2024 •

edited

Loading

This is about using async where it's available.

Some of the changed places used SafeDispose() earlier. Not sure how important that was, but it wasn't used consistently.


          Use DisposeAsync with scopes and hosts

b23ae8c

Member

jeremydmiller commented Sep 25, 2024

SafeDispose is trying to swallow any exceptions from Dispose(), which isn't terribly uncommon here and there

jeremydmiller merged commit 0432255 into JasperFx:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet