Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify warning about metadata in inline projections #3432

Conversation

thomaslevesque
Copy link
Contributor

This limitation no longer applies, according to #3431 (comment)

@jeremydmiller
Copy link
Member

@thomaslevesque Actually needs more context rather than removing that. That is long, long obsolete if you use the Rich Append mode (the default), but goes back to being true if opting into the faster "quick append" mode.

https://www.youtube.com/watch?v=CQeezCdF4mk

@thomaslevesque
Copy link
Contributor Author

@jeremydmiller ah, I see, thanks.
So, if I understand this correctly, the IEvent.Version and IEvent.Sequence aren't available in inline projections when using "Quick" append mode, but the rest of the metadata is available?

@jeremydmiller
Copy link
Member

@thomaslevesque Correct. All about compromises. The "rich append" mode was put in place for Marten 4 because people wanted to use the event sequence and stream version data in inline projections, but it turns out that comes with a big perf cost, potentially causes a lot of concurrency issues, and makes the async daemon more prone to skipping events. So back came the <=3.0 "quick append" behavior.

Except just to make it more complicated, the new quick append method can at least use the correct stream version within aggregates stored in the database along the way. The event sequence is only assigned at the time the events are persisted though.

@thomaslevesque
Copy link
Contributor Author

OK, thanks for the explanation. I'll try to reword the warning to make things clearer

@jeremydmiller
Copy link
Member

@thomaslevesque Thank you for taking this on!

@thomaslevesque thomaslevesque changed the title Remove warning about metadata in inline projections Clarify warning about metadata in inline projections Sep 23, 2024
@thomaslevesque
Copy link
Contributor Author

@jeremydmiller is that better?

@mysticmind mysticmind changed the title Clarify warning about metadata in inline projections docs: Clarify warning about metadata in inline projections Sep 25, 2024
@mysticmind
Copy link
Member

@thomaslevesque the changes look fine.

@mysticmind mysticmind merged commit 84b6300 into JasperFx:master Sep 25, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants