bug: Inline projections don't have correct version when appending to an existing stream (quickappend) #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elexisvenator
changed the title
jeremydmiller
added a commit
that referenced
this pull request
Jul 17, 2024
14 tasks
|
Got it with some merge/rebase clumsiness. @elexisvenator Thanks for doing all the work to find this issue and to repro it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found as part of #3307, Inline projections take their revision from the version of the last event appended to a stream, but for quickAppend this is not a valid version.
This is the tests I was using for performance, one of them is failing due to this issue, so the rest can be removed if you dont care about them. The size of the streams / iterations are scaled way back to make the tests fast.