Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma delimited lists #11

Merged
merged 6 commits into from
May 2, 2019
Merged

Comma delimited lists #11

merged 6 commits into from
May 2, 2019

Conversation

JasonEtco
Copy link
Owner

@JasonEtco JasonEtco commented May 2, 2019

This PR allows for lists (assignees and labels) to be comma-delimited:

# Before
labels:
  - bug
  - other

# After
labels: bug, other

Like @janester pointed out in #10, this is more in-line with GitHub's issue templates, so the templates will still work even out of this Action ✨

I've kept support for array lists, but changed the behavior explained in the README to use string-delimited lists since that should be the "right way."

Closes #10

@JasonEtco JasonEtco changed the title Sting delimited lists Comma delimited lists May 2, 2019
@JasonEtco JasonEtco merged commit 5c1234b into master May 2, 2019
@JasonEtco JasonEtco deleted the sting-delimited branch May 2, 2019 15:04
@janester
Copy link

janester commented May 2, 2019

Thanks for 🚢ing this so quickly!! 💖

@aaronfranke
Copy link

How does this work for assignees? Do you need an @ in front of the name?

@JasonEtco
Copy link
Owner Author

How does this work for assignees? Do you need an @ in front of the name?

@aaronfranke nope - you can see an example in the README:

---
title: Someone just pushed
assignees: JasonEtco, matchai
labels: bug, enhancement
---
Someone just pushed, oh no! Here's who did it: {{ payload.sender.login }}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assignees and labels shouldn't be an array
3 participants