-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to include additional files #18
base: main
Are you sure you want to change the base?
Conversation
Include files other than `main` when creating a commit to update a tag. This will not be needed by most people, but is required if you're bundling `ncc` using `ncc` due to `Error: ENOENT: no such file or directory, open '/home/runner/work/_actions/owner/repo/v1/dist/index.js.cache.js'`
Just saw this and I would need the same functionality to include a license file with the releases. @JasonEtco could you please consider this for merging? |
I'd really like to have this feature! Example:
|
@JasonEtco any chance you might want to integrate this or #24? I would really like to include the README into the release tag (so that viewing older releases on the marketplace also shows the readme). See for example an older version of this action itself: |
Any updates over here ? |
I'd really like this too. Love the workflow of this action but need to include a wasm file along side the ncc generated |
Cherry-picked from mheap/build-and-tag-action@ 3c1fd24 which is and open PR on JasonEtco/build-and-tag-action: JasonEtco#18 Include files other than `main` when creating a commit to update a tag. This will not be needed by most people, but is required if you're bundling `ncc` using `ncc` due to `Error: ENOENT: no such file or directory, open '/home/runner/work/_actions/owner/repo/v1/dist/index.js.cache.js'`
@mheap turns out there's a bug in the PR (technically a bug exposed by this PR as it enables deployment of binaries). I forked into our org and used it to deploy a wasm with an action (as mentioned before) but discovered that the binary was corrupted by the roundtrip through utf-8. See primait@183ecd8 |
@EddieWhi Excellent catch! I've cherry picked in to this PR in case it helps anyone else |
The readme should be included in the tag as well. Otherwise when selecting an older version in the marketplace there is no readme displayed. See also here: JasonEtco/build-and-tag-action#18 (comment)
The readme should be included in the tag as well. Otherwise when selecting an older version in the marketplace there is no readme displayed. See also here: JasonEtco/build-and-tag-action#18 (comment)
Include files other than
main
when creating a commit to update a tag. This will not be needed by most people, but is required if you're bundlingncc
usingncc
due toError: ENOENT: no such file or directory, open '/home/runner/work/_actions/owner/repo/v1/dist/index.js.cache.js'