Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return form table in fotmob_get_league_tables() #281

Merged
merged 6 commits into from
May 29, 2023

Conversation

tonyelhabr
Copy link
Collaborator

@tonyelhabr tonyelhabr commented May 27, 2023

Addresses #279. I actually had a TODO for this as well 😄 .

> table <- fotmob_get_league_tables(league_id = 47)
> dplyr::glimpse(table)
Rows: 80
Columns: 19
$ league_id               <int> 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, …
$ page_url                <chr> "/leagues/47/overview/premier-league", "/leagues/47/overview/premier-lea…
$ table_type              <chr> "all", "all", "all", "all", "all", "all", "all", "all", "all", "all", "a…
$ table_name              <chr> "Manchester City", "Arsenal", "Manchester United", "Newcastle United", "…
$ table_short_name        <chr> "Man City", "Arsenal", "Man United", "Newcastle", "Liverpool", "Brighton…
$ table_id                <int> 8456, 9825, 10260, 10261, 8650, 10204, 10252, 8586, 9937, 9879, 9826, 84…
$ table_page_url          <chr> "/teams/8456/overview/manchester-city", "/teams/9825/overview/arsenal", …
$ table_deduction         <lgl> NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, …
$ table_ongoing           <lgl> NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, …
$ table_played            <int> 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, 37, …
$ table_wins              <int> 28, 25, 22, 19, 19, 18, 17, 17, 14, 15, 11, 11, 11, 11, 11, 9, 7, 8, 7, …
$ table_draws             <int> 5, 6, 6, 13, 9, 8, 7, 6, 14, 7, 11, 10, 8, 7, 6, 10, 12, 7, 10, 6, 1, 3,…
$ table_losses            <int> 4, 6, 9, 5, 9, 11, 13, 14, 9, 15, 15, 16, 18, 19, 20, 18, 18, 22, 20, 25…
$ table_scores_str        <chr> "94-32", "83-43", "56-42", "67-32", "71-43", "71-51", "49-45", "66-62", …
$ table_goal_con_diff     <int> 62, 40, 14, 35, 28, 20, 4, 4, 11, 3, -9, -9, -22, -12, -33, -30, -24, -1…
$ table_pts               <int> 89, 81, 72, 70, 66, 62, 58, 57, 56, 52, 44, 43, 41, 40, 39, 37, 33, 31, …
$ table_idx               <int> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 1…
$ table_qual_color        <chr> "#2AD572", "#2AD572", "#2AD572", "#2AD572", "#0046A7", "#0046A7", "#02CC…
$ table_featured_in_match <lgl> NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA, …
> unique(table$table_type)
[1] "all"  "home" "away" "form"

Should merge after #280. (I intentionally already bumped the package version 2 ticks.)

@tonyelhabr
Copy link
Collaborator Author

Failing tests are either related to #278 or fixed by #280

@tonyelhabr tonyelhabr requested a review from JaseZiv May 28, 2023 14:11
Copy link
Owner

@JaseZiv JaseZiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks heaps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants