Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tm_player_bio() throws error #57

Closed
mca91 opened this issue Sep 23, 2021 · 3 comments
Closed

tm_player_bio() throws error #57

mca91 opened this issue Sep 23, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mca91
Copy link

mca91 commented Sep 23, 2021

Hi Jason,

great package! Would have saved me a lot of time and work if I had learned about it earlier! :)

I just went through the vignette and tried a few of the examples. It seems to me that there is a (dplyr related) bug in tm_player_bio():

Running

hazard_bio <- tm_player_bio(player_url = "https://www.transfermarkt.com/eden-hazard/profil/spieler/50202")

gives me

Error: Problem with `filter()` input `..1`.
Input `..1` is `!stringr::str_detect(.data$X1, "Social-Media")`.
Column `X1` not found in `.data`
Run `rlang::last_error()` to see where the error occurred.

Any ideas?

Best,
Martin

@JaseZiv
Copy link
Owner

JaseZiv commented Sep 23, 2021

Glad the package helps!

It appears something may have changed in the html. I'll have to investigate this and try to fix asap.

Thanks for picking this up!

@JaseZiv JaseZiv added the bug Something isn't working label Sep 23, 2021
@JaseZiv JaseZiv self-assigned this Sep 23, 2021
JaseZiv added a commit that referenced this issue Sep 23, 2021
@JaseZiv
Copy link
Owner

JaseZiv commented Sep 23, 2021

@mca91 This should be fixed now. Reinstall the package and let me know if there's any issues moving forward.

Thanks for picking it up.

@JaseZiv JaseZiv closed this as completed Sep 23, 2021
@mca91
Copy link
Author

mca91 commented Oct 1, 2021

I just tested it – works fine now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants