-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Userfriendly Launcher for Audiobook Maker #64
Conversation
Great! I'll test it this weekend |
@JarodMica any updates on this? i was wondering if i need to change something or that it can be merged |
First, thanks for taking the time to make the script, finally got around to testing it right now and there some issues to check. 7zip installation issue - doesn't register correctly in the path, end up just getting the output:
I've already got 7zip installed on my computer as well, it could be causing this issue, possibly add an option to skip install of 7zip if already installed. Or maybe, a solution to cover both cases I think would be just to download the .7z exe file into the audiobook root and use that instead. The same being for ffmpeg as well. If ffmpeg and ffprobe are in the root dir or the audiobook maker, it doesn't need to be installed in the users path. Additionally, for the package install, I run into a bit of issues with conda
and the rest of the installation proceeds. There are some additional issues that I think stem from not being able to find path specified, so I get the error like:
If the script used the root of the audiobook folder, I think it might be easier that way. |
@JarodMica Hi thanks for the feedback I have fixed the conda error and made it now a localized package that will be installed in the userdata folder inside audiobook_maker... i added the userdata to gitignore because its only used for users where the virtual env will be deployed into i also fixed the 7zip so it will check if its installed and added to PATH so it can be used globally as a command the same for ffmpeg Demo: vmware_W1DkU581r8.mp4 |
Hey @deffcolony, I apologize for having had you spend the extra time to adjusting the script, but I won't be merging into the the repository. I realized that after some issues, it's another thing I'll have to maintain and respond to new issues with and then I'm not familiar enough with the way the batch script is created to make adjustments to it. The philosophy for why I've broken my manually installation into individual pieces is to make transparent what's being installed as I think this would enable for easier debugging on my end. However, if it's fine with you, I can put a link to your fork for people to try out as an alternative way to install it. That way, if you make adjustments to it, it'll be the most up-to-date. One final thing, I ran into issues on my main PC trying to install and then on my secondary, both seem to be due to curl not being found in spite of curl being available on my computers. I used pauses to debug where the point in the script was crashing. |
Pull Request Summary: A Simple Userfriendly Launcher V2
Description
This pull request introduces several features to the Audiobook Maker launcher script, providing a more user-friendly and automated experience. The primary features include:
Automatic FFmpeg Installation
User-Friendly Menu
Usage
Users can interact with the script by simply running
audiobook-launcher.bat
and selecting options from the displayed menu. The script handles the installation, configuration, and uninstall of the Audiobook MakerTesting
The script has been tested to ensure a smooth installation, proper configuration, and seamless uninstallation. User input handling and automated actions have been thoroughly tested to provide a reliable and user-friendly experience.
Additional Notes