Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ipfs transport to use the latest ipfshttpclient, updated README, updated script files, added requirements file #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mibofra
Copy link

@mibofra mibofra commented Jul 21, 2019

As written in the title

In the requirements file, there aren't the versions of the libraries, as I prefer to update the code when it breaks, instead of binding it to specific libraries revisions, to make it always up-to-date.

Anyway, this are the versions I'm using at the moment:

base58              1.0.3
ipfshttpclient      0.4.12
multiaddr           0.0.8
varint              1.0.2

…ME, updated script files, added requirements file
@mibofra
Copy link
Author

mibofra commented Oct 19, 2019

@ElOpio Why did you deliberately changed the master to accept the modifications, instead of accepting my pull request? i've seen the date of both commits, and my request is prior to the 31 Jul, the date of your last commit.

@come-maiz
Copy link
Member

Sorry @mibofra! I did it quickly in my local machine without checking if something new was in github.
Give me a few days and I will resolve your conflicts, add the nice changes you made and I didn't, and add you as a contributor.

Thanks!

@mibofra
Copy link
Author

mibofra commented Oct 19, 2019

Don't worry, it can happen. My changes are more or less the same, updating it to use the latest ipfshttpclient, as said before. Just I need to use the transport, so I wanted to contribute back the modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants