server/ui: associate user timing profile #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NextFire
force-pushed
the
feat/associate-timing-profile
branch
3 times, most recently
from
db8517f to
953a692
Compare
odrling
requested changes
Nov 13, 2024
odrling
reviewed
Nov 17, 2024
odrling
approved these changes
Nov 17, 2024
This reverts commit 39f49af.
seems mostly unnecessary (special case for nil when it could be another function) also changes the uses of First without where because it is not explicit enough (which caused issues in the past)
odrling
force-pushed
the
feat/associate-timing-profile
branch
from
0320f99 to
7e913ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #51
Preferred merge strategy: squash