Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test as flaky for all backends #4309

Conversation

FlorianHockmann
Copy link
Member

We only annotated the test for CQL as flaky, but it's also flaky for other backends. contributor @kptfh already commented on the issue that it's also flaky for the Aerospike backend:
#1498 (comment)

and Natalia recently commented on Discord that the test is flaky for in-memory.

So, we should just move the annotation to the test itself to be not specific for any backend. Since the test is copied to JanusGraphCustomIdTest, we also need the annotation there (and this is also the place where Natalia hit the flaky test).

Issue: #1498 (not fixed by this)


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

We only annotated the test for CQL as flaky, but
it's also flaky for other backends. contributor
@kptfh already commented on the issue that it's
also flaky for the Aerospike backend:
JanusGraph#1498 (comment)

and Natalia recently commented on Discord that the test is flaky for
in-memory.

So, we should just move the annotation to the test itself to be not
specific for any backend.
Since the test is copied to `JanusGraphCustomIdTest`, we also need the
annotation there (and this is also the place where Natalia hit the flaky
test).

Issue: JanusGraph#1498 (not fixed by this)

Signed-off-by: Florian Hockmann <[email protected]>
@FlorianHockmann FlorianHockmann merged commit e955783 into JanusGraph:master Mar 12, 2024
110 checks passed
@FlorianHockmann FlorianHockmann deleted the Issue_1498_MarkTestAsFlakyForAllBackends branch March 12, 2024 07:27
@janusgraph-automations
Copy link

💚 All backports created successfully

Status Branch Result
v1.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants