Mark test as flaky for all backends #4309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only annotated the test for CQL as flaky, but it's also flaky for other backends. contributor @kptfh already commented on the issue that it's also flaky for the Aerospike backend:
#1498 (comment)
and Natalia recently commented on Discord that the test is flaky for in-memory.
So, we should just move the annotation to the test itself to be not specific for any backend. Since the test is copied to
JanusGraphCustomIdTest
, we also need the annotation there (and this is also the place where Natalia hit the flaky test).Issue: #1498 (not fixed by this)
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: